mjarkk / vanmoof-web-controller

Change the speed limit of a VanMoof S3 or X3 via a website
https://mooovy.app
GNU Lesser General Public License v2.1
79 stars 14 forks source link

Partly added auto theming for dark/white mode (systematic) #21

Closed sanderDijkxhoorn closed 1 year ago

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
vanmoof-web-controller ✅ Ready (Inspect) Visit Preview Jul 1, 2022 at 8:58PM (UTC)
sanderDijkxhoorn commented 2 years ago

I think it's pretty clear how to use it, I left some comments but I am not really sure which colors to use so I haven't added the actual colors yet.

mjarkk commented 2 years ago

I suspect with only this code the app will support dark mode but will look ugly as a tough the widgets specific colors are used and those should also change.

Either:

  1. Base specific color usage on variables from the Theme (Theme.of(context)...) and within the Theme modify fields to set custom colors
  2. Use an (inline) if statement on places where colors are used and depending on the color theme on that moment select a color (Container(color: isDarkMode ? Colors.red[800] : Colors.red[200]))
sanderDijkxhoorn commented 2 years ago

I suspect with only this code the app will support dark mode but will look ugly as a tough the widgets specific colors are used and those should also change.

Either:

  1. Base specific color usage on variables from the Theme (Theme.of(context)...) and within the Theme modify fields to set custom colors

  2. Use an (inline) if statement on places where colors are used and depending on the color theme on that moment select a color (Container(color: isDarkMode ? Colors.red[800] : Colors.red[200]))

I am currently still in Berlin, I might get home late today or we will split the ride in 2 parts and stay somewhere tonight and continue tomorrow. Either way I can probably start working on this in like 3 days :)

mjarkk commented 2 years ago

That's all oke, Take your time!