search

mjbarlow / Umbraco-8-Bulma-Starter-Kit

Free starter kit / theme for Umbraco v8+, based on the Bulma CSS framework.
https://bulma.jacker.io
MIT License
8 stars 5 forks source link

Rebuild Models in U8StarterKit.Web.Models.Umbraco Using Models Builder 8.1.0 #2

Closed paulsterling closed 5 years ago

paulsterling commented 5 years ago

After an upgrade to 8.1.0 the site renders with the error

Cannot bind source content type Umbraco.Web.PublishedCache.NuCache.PublishedContent to model type U8StarterKit.Web.Models.Umbraco.Home

I believe, due to updates in Umbraco IPublishedContent and Bulma Starter Kit's custom models approach, all the custom models will need to be regenerated against the new ModelsBuilder and IPublishedContent in Umbraco 8.1.0.

There may be other places where updates will be required as well as 8.1.0 introduced a number of breaking changes: https://our.umbraco.com/documentation/Getting-Started/Setup/Upgrading/v81-ipublishedcontent-changes

I'll try to get to this, but wanted to capture the issue in case others had input or want to get started on the updates.

Shaggy2408 commented 5 years ago

Is this issue Also related to this post

https://our.umbraco.com/packages/starter-kits/bulma-starter-kit/bulma-starter-kit-for-v8/98417-falink-does-not-work

cherylcarpenter commented 5 years ago

For my team, the kit as distributed in the package was never going to work for us, as we need the modelsbuilder to work and could not do so with the distributed model/dll version. I downloaded source files from this repo, used the models builder in the AppData mode, and we've not had any issues upgrading to 8.1.0. For us, the repo version has worked much better than the package on umbraco. But our skill set is more frontend.

That said, falink gave us lots of fits at first due to not having null checks. As we changed the templates for !=null everywhere, falink has been fine.

Hope you don't mind my 2cents. When we went with Umbraco 8 a few months back, this was the most robust kit to start from and it is serving us weel.

paulsterling commented 5 years ago

Hi @cherylcarpenter - That sounds like a solid approach...along the lines of what I've been considering as well. Would you be willing to create a new branch and send a PR to this repo with your changes? Perhaps that could jumpstart the process to get the starterkit moved over to models builder by default. I'd love to see that for one: https://twitter.com/paulsterling/status/1136377896006590465

cherylcarpenter commented 5 years ago

Would you be willing to create a new branch and send a PR to this repo with your changes?

oh hah, i can try given a day or two-- I'm really a hack :) I liked the 3-projects in one solution seen here, and kept fiddling til it worked with a blank database lol. Here's my webconfig add key="Umbraco.ModelsBuilder.Enable" value="true" add key="Umbraco.ModelsBuilder.ModelsMode" value="AppData" add key="Umbraco.ModelsBuilder.ModelsNamespace" value="MyProject.Core.Models" add key="Umbraco.ModelsBuilder.ModelsDirectory" value="~/../MyProject.Core/Models" add key="Umbraco.ModelsBuilder.AcceptUnsafeModelsDirectory" value="true"

And yes just search and replace the namespaces throughout. My goal being to get to my blank install Admin side to push the models builder button. I'll see what i can branch to here.

PS-- oh yeah, i had a blank project, installed Umbraco, installed the U8StarterKit so that it populated my database, then started over with this source code. So, as a complete hack, i have no idea how to start with models and get it 'into' a database in the form of content. This was the hacky step.

cherylcarpenter commented 5 years ago

PS--

oh yeah, AND make sure the FaLinks dll is 'Included' in the VS project. VisualStudio/.NET really are from hell for the front end developer.

cherylcarpenter commented 5 years ago

I found the gotcha, i apologize for the rabbit hole. I had indeed updated to 8.1 and everything worked. It breaks when generating any new models with the updated ModelsBuilder. Reading through the breaking changes (in minor revision numbers again) on IPublishedContent. I'm guessing there is needed updates in the GetFaLinks as HasValue() no longer works on the FaLinks object. And that's the extent of my skill level and I will downgrade to v8, until the FaLinks rewritten or we work round. Thanks.

mjbarlow commented 5 years ago

Thanks guys, I've updated the Starter Kit to work with Umbraco version v8.2.0, also the models mode is now set to DLL, so the models are no longer included in the main project Dll and can be regenerated as required. Thanks for using my starter kit! :)

Shaggy2408 commented 5 years ago

Hi there,

I am getting this error

[cid:image004.png@01D58B60.04301940]

[cid:image005.png@01D58B60.04301940] Shahid Mahmood Hussain Senior Solution Architect, Dynamics 365 Mobile: +45 26 85 74 97

Abakion A/S | Vibenshuset, Lyngbyvej 2 | 2100 København Ø | Danmark | + 45 70 23 23 17 Abakion.dkhttps://abakion.dk | Abakion.comhttps://abakion.com | Facebookhttps://www.facebook.com/abakion.dk | LinkedInhttps://www.linkedin.com/company/abakion-as From: mjbarlow notifications@github.com Sent: 24. oktober 2019 18:18 To: mjbarlow/Umbraco-8-Bulma-Starter-Kit Umbraco-8-Bulma-Starter-Kit@noreply.github.com Cc: Shahid M. Hussain smh@dynateam.dk; Comment comment@noreply.github.com Subject: Re: [mjbarlow/Umbraco-8-Bulma-Starter-Kit] Rebuild Models in U8StarterKit.Web.Models.Umbraco Using Models Builder 8.1.0 (#2)

Thanks guys, I've updated the Starter Kit to work with Umbraco version v8.2.0, also the models mode is now set to DLL, so the models are no longer included in the main project Dll and can be regenerated as required. Thanks for using my starter kit! :)

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmjbarlow%2FUmbraco-8-Bulma-Starter-Kit%2Fissues%2F2%3Femail_source%3Dnotifications%26email_token%3DACN7T3LRBN4N5RZURKSFL2LQQHDDHA5CNFSM4IE6DAO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECFTIRY%23issuecomment-545993799&data=01%7C01%7Csmh%40abakion.com%7C0caa63a051454ff0ea8e08d7589dbed0%7Cc004bd17f2d6493b8e5ec275adeed22f%7C0&sdata=7aNp9KN7gNKcths7zTcDERwZpQ%2BkUicPfk9YaLe5F%2FU%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACN7T3I2IHSASJCD2YN5DOLQQHDDHANCNFSM4IE6DAOQ&data=01%7C01%7Csmh%40abakion.com%7C0caa63a051454ff0ea8e08d7589dbed0%7Cc004bd17f2d6493b8e5ec275adeed22f%7C0&sdata=l0IZbZkAOzoVKHvlaOu046tiM3PNmcomU6OIC%2BmbuNs%3D&reserved=0.

Shaggy2408 commented 5 years ago

Hi There,

i am getting this error

image