search

mjbellantoni / formtastic-bootstrap

Formtastic form builder to generate Twitter Bootstrap-friendly markup.
MIT License
444 stars 217 forks source link

Field with errors does not display inline messages with input as :check_boxes #102

Closed jjp closed 10 years ago

jjp commented 10 years ago

Scenario: Given a field that has errors When I display the field within an input type as :check_boxes and configuring to display errors inline - I expect to the the error string below that field.

With formtastic-bootstrap (3.0.0) that is not the case. I do not see the error message.

I do have a proposed fix for this and can send a pull request, but I'd like to verify that my fix does not break anything. However, I can't seem to get specs to run properly given my recently forked clone.

Can someone provide guidance on how to get the test suite to run?

Current suite fails with: uninitialized constant Rails::VERSION (NameError)

Attempts to fix this just cause more issues.

sodabrew commented 10 years ago

Unfortunately the specs are not in great shape right now. Please do open a PR and we can help work through it.

jjp commented 10 years ago

Pull request sent.

sodabrew commented 10 years ago

Please let me know if the merged version of #103 works, and we'll close out this bug.

jjp commented 10 years ago

Looks A-OK now. Thx!

sodabrew commented 10 years ago

Thanks for confirming!

waiting-for-dev commented 10 years ago

Hey, it seems is is still an issue in master