search

mjbellantoni / formtastic-bootstrap

Formtastic form builder to generate Twitter Bootstrap-friendly markup.
MIT License
444 stars 217 forks source link

Formtastic removed GroupedCollections included in `select_input.rb` but Formtastic Bootstrap didn't #108

Closed siruguri closed 9 years ago

siruguri commented 9 years ago

In lib/formtastic-bootstrap/inputs/select_input.rb, this line should be deleted

include Base::GroupedCollections

Due to this commit made in Formtastic.

sodabrew commented 9 years ago

We haven't updated formtastic-bootstrap for Formtastic 3 at all yet, so this is probably the first of many changes that would be needed. Are you seeing that Formtastic 3 works besides this issue?

siruguri commented 9 years ago

My bad, I read "Bootstrap 3" and my brain said "Formtastic 3", in your README.

So I have a very simple form, and yes, it "works" for the string, date_select, and select pickers I used.

FWIW, I tried to compare rake spec with the formtastic dependency bumped to 3.0. I am not quite sure I'm doing the right thing - I found that in fact your gemspec already says >=2.2 - doesn't that mean you would also get Formtastic 3.0 in your tests, if you updated your bundle for whatever reason?

At any rate, I found that 3.0 doesn't seem to generate more errors - 2.3 also generates plenty of rake spec errors.

But feel free to close/postpone this issue until you are supporting Formtastic 3 formally.

sodabrew commented 9 years ago

I would want to figure out if we need to selectively include Base::GroupedCollections based on which version of Formtastic is available.

siruguri commented 9 years ago

Or include it only if it's defined? That would be a backward compatible change that would at least get folks with Formtastic 3 going. s.

On Wed, Sep 24, 2014 at 1:57 PM, Aaron Stone notifications@github.com wrote:

I would want to figure out if we need to selectively include Base::GroupedCollections based on which version of Formtastic is available.

— Reply to this email directly or view it on GitHub https://github.com/mjbellantoni/formtastic-bootstrap/issues/108#issuecomment-56737594 .

ebach2 commented 9 years ago

something along the lines of if Formtastic::Inputs::Base.const_defined?(:GroupedCollections) include Formtastic::Inputs::Base::GroupedCollections end in Formtastic-Bootstrap::inputs::base::groupedcollections

sodabrew commented 9 years ago

Resolved by #116