Added input and action namespacing for formtastic 3.1

mjbellantoni / formtastic-bootstrap

Formtastic form builder to generate Twitter Bootstrap-friendly markup.

MIT License

444 stars 217 forks source link

Added input and action namespacing for formtastic 3.1 #116

Closed jkelleyj closed 9 years ago

jkelleyj commented 9 years ago

cleanup on specs for previous input helper
cleanup on specs for previous action helper
upgrade rspec to 2.14 to sync with formtastic
remove some deprecation warnings for rspec upgrade to 2.14

jkelleyj commented 9 years ago

@sodabrew here's a preliminary PR. I cleaned up some specs that were broken, but there are a nice chunk still busted that I don't have time to clear up right now. I started working on the select input because it seems to have some formtastic 3.1 issues now that grouped collections are out. I could use a little help there to make sure I'm not blasting away anything important.

sodabrew commented 9 years ago

Nice work! I wrote up a bunch of inline comments, and then just saw that you addressed some of them already... about the namespaced finders. Could you take a look at #112 and advise if it impacts the functionality that @gbisheimer added?

sodabrew commented 9 years ago

Ok, this looks good. Are you ready for me to merge it or do you have some more changes in mind?

jkelleyj commented 9 years ago

Yeah, let's move ahead with this. Could you confirm that the tests are not any worse off from where you had them previously? I was counting 132 errors in the fresh cut and have it down to 118. I did remove a couple of specs where the functionality was now fully handled by Formtastic. I don't think that I broke any new specs, but honestly haven't dug into that. I'll put another commit on a separate PR for the select input GroupedCollections issue

sodabrew commented 9 years ago

Awesome, here goes!