search

mjbrown / bgapi

A python package for communicating with BlueGiga modules through their proprietary API.
39 stars 25 forks source link

Py3 00 #18

Closed pinkavaj closed 8 years ago

pinkavaj commented 8 years ago

Hi,

I'm slowly going towards Python 3 port of this library. It would be nice to support both Python 2 and 3 in the same code base. More changes will come latter but it looks like it might work (I have it already done, but needs a lot of clean-up). There is one catch, supporting all of Python 2.6, 2.7 and 3.x might be a bit troublesome. Is there any need to support python 2.6?

mjbrown commented 8 years ago

I will test it on both this weekend.

pinkavaj commented 8 years ago

What exactly do you mean by "both"?

mjbrown commented 8 years ago

I will test it with 2.7 and 3.5.

On Fri, May 13, 2016 at 8:14 AM, Jiří Pinkava notifications@github.com wrote:

What exactly do you mean by "both"?

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/mjbrown/bgapi/pull/18#issuecomment-219039141

pinkavaj commented 8 years ago

There are still few patches missing to make it really work with 3.x, this is just try if You are interested in this port. I will try to finish it son and push it. Thanks for fast response.

pinkavaj commented 8 years ago

This should do it. I have only tested it on my project (using only api.py). I have only one dongle now, thus I cannot run the test..

Check if you are ok with the changes.

mjbrown commented 8 years ago

Except for the directed connectable problem, the 2-dongle test runs fine in both 2.7 and 3.5.