search

mjbshaw / minigames

3 stars 1 forks source link

appending a game of 2048? #2

Open MajorBarnulf opened 2 years ago

MajorBarnulf commented 2 years ago

Hi, A while ago I made a TUI game of 2048

depending on how serious this project is and how concrete the interface for games become, I might port this game to here.

mjbshaw commented 2 years ago

Cool! A PR integrating that is certainly welcome. The only part I'm not sure about is the license: that crate is GPL but this crate is MIT/Apache (same as the Rust toolchain). It's probably fine but by default I'm generally wary of the complexities that arise from mixing different licenses (not just GPL).

MajorBarnulf commented 2 years ago

I'd like to help integrating it, but for now this crate seems pretty bare; maybe work should be made on a component managing and switching between available games.

About the licensing, I have split my crate into a binary crate and a library that contains every components necessary to run a game, the library is MIT, which I guess is better?