mjbvz / vscode-github-markdown-preview-style

VS Code extension that changes the built-in markdown preview to match Github's styling
https://marketplace.visualstudio.com/items?itemName=bierner.markdown-preview-github-styles
MIT License
301 stars 57 forks source link

Differences in code blocks: Border Width and the Scrollbar #115

Open Phroneris opened 11 months ago

Phroneris commented 11 months ago

Description

In the preview provided by this extension, borders and scrollbars of code blocks are different from those on the actual GitHub.

GitHub's Behavior

Rendering:

.very-long-content {
  content: "very long content very long content very long content very long content very long content very long content very long content very long content very long content very long content";
}

Screenshot:

ext-issue-very-long-content-github

Extension's Behavior

Screenshot:

ext-issue-very-long-content-extension

Difference:

While the detailed design of the scrollbar is also up to the browser, the border is clearly different at least.

Specs

jjspace commented 11 months ago

The border color is showing up because you have the widgets.border color defined in your settings or the theme you are using for VSCode. I just opened a PR to stop using that https://github.com/mjbvz/vscode-github-markdown-preview-style/pull/116

The scrollbar looks different because VSCode has created a custom one which is also being used inside the markdown preview. There is no way to override or revert a custom scrollbar so unless someone wants to re-implement one that looks close to the default browser one I'm not sure that's something we can address.

Phroneris commented 10 months ago

Congrats on the PR being merged 🎉

ext-issue-very-long-content-extension-fixed