mjbvz / vscode-github-markdown-preview-style

VS Code extension that changes the built-in markdown preview to match Github's styling
https://marketplace.visualstudio.com/items?itemName=bierner.markdown-preview-github-styles
MIT License
301 stars 57 forks source link

Broken Layout of Callout Blocks (2.0.4) #135

Open augustsaintfreytag opened 4 months ago

augustsaintfreytag commented 4 months ago

Since one of the last updates, GitHub-typical callout blocks no longer render with the correct indentation and spacing. I'm certain they used to render correctly (as they appear on GitHub) in prior versions. I'm using extension version 2.0.4 in VSCode 1.87.2 on Windows 11.

image

jjspace commented 4 months ago

As mentioned in https://github.com/mjbvz/vscode-github-markdown-preview-style/issues/134 this is not a feature supported by this extension at this time. Please report to the additional extension you have for alerts. I'm assuming that's yahyabatulu.vscode-markdown-alert which already has an issue here https://github.com/ByPikod/vscode-markdown-alert/issues/4

d-kleine commented 4 months ago

As mentioned in #134 this is not a feature supported by this extension at this time. Please report to the additional extension you have for alerts. I'm assuming that's yahyabatulu.vscode-markdown-alert which already has an issue here ByPikod/vscode-markdown-alert#4

@jjspace That's correct, it's intended that way, see below @augustsaintfreytag Please also see here

augustsaintfreytag commented 4 months ago

Well, if that's the case, you can close this as "works as intended".

I haven't been using the Markdown Alert extension but I did have Markdown All in One and either seem to enable rendering callout blocks. They do it in a way that it actually also appears broken in the same way. Both enable a proper rendering of callout blocks in vanilla, without the GitHub styling extension.

So I guess the fact that this used to render correctly for a few months was just a fluke or an unwanted side effect. I think one of these extensions allows for custom styling for the output so I'm going to have to make some custom adjustments for the time being.