search

mjbvz / vscode-github-markdown-preview-style

VS Code extension that changes the built-in markdown preview to match Github's styling
https://marketplace.visualstudio.com/items?itemName=bierner.markdown-preview-github-styles
MIT License
303 stars 57 forks source link

Pluggin do not work anymore #18

Closed transit-ericmckay closed 6 years ago

transit-ericmckay commented 6 years ago

It is possible that the pluggin don't work with 1.21.0 Version of VSCode?

image

glennsarti commented 6 years ago

Same here. The preview styling has revertted back to "vanilla" VS Code styling. I have the same version of VSCode.

Windows 10 (1709)

glennsarti commented 6 years ago

I assume this fix is required? https://github.com/Microsoft/vscode/commit/ccc8f5ab36b3d27ed81ff72d03d6ccbc53214ae4

linuxiamo commented 6 years ago

Thanks @glennsarti , but how do we apply the patch?

glennsarti commented 6 years ago

@linuxiamo To be honest, no idea. Either use the nightly builds of VS Code, or just wait till the next release. In my case I'm happy to wait, others may be different.

glennsarti commented 6 years ago

... and the latest build of VS Code just landed and it's fixed!

image

transit-ericmckay commented 6 years ago

Hallelujah! Thanks for sharing!!