search

mjbvz / vscode-github-markdown-preview-style

VS Code extension that changes the built-in markdown preview to match Github's styling
https://marketplace.visualstudio.com/items?itemName=bierner.markdown-preview-github-styles
MIT License
303 stars 57 forks source link

Border colors of table cells are overridden by the default style #2

Closed yume-chan closed 6 years ago

yume-chan commented 7 years ago

VSCode version: 1.15.0 Extension version: 0.0.2

The border rule at Line 530 is overridden by the default .vscode-dark table > thead > tr > th { border-color: rgba(255, 255, 255, 0.69); } and .vscode-dark table > tbody > tr + tr > td { border-color: rgba(255, 255, 255, 0.18); } rules, causing the borders are missing.

| Column 1 | Column 2 |
|----------|----------|
| Test     | Test     |
| Test     | Test     |
| Test     | Test     |

image

This a easy fix, but I don't know where does your github-markdown.css come from, or can I edit it directly.

qjebbs commented 7 years ago

I recommend you override it again in base.css with !important, because github.css is auto generated.