search

mjbvz / vscode-github-markdown-preview-style

VS Code extension that changes the built-in markdown preview to match Github's styling
https://marketplace.visualstudio.com/items?itemName=bierner.markdown-preview-github-styles
MIT License
303 stars 57 forks source link

Not working in VSCode 1.24.0 #24

Closed Gliptal closed 6 years ago

Gliptal commented 6 years ago

As per title, this doesn't work on VSCode 1.24.0: the preview seems to use the default stylesheet.

mschleeweiss commented 6 years ago

Have you properly restarted VSCode?

For me it didn't work right after installation. However after manually restarting VSCode it did work.

Gliptal commented 6 years ago

Yeah, still getting the default sytle.

Note that 1.24.0 also changed the default style around, maybe it's connected?

mjbvz commented 6 years ago

Did you close and then re-open the preview after reloading? (see https://github.com/Microsoft/vscode/issues/51733)

Gliptal commented 6 years ago

Yes tried that as well.

mjbvz commented 6 years ago

With the preview open, run the Open Webview developer tools command in vscode. Are there any errors listed in the developer console?

Gliptal commented 6 years ago

Good catch:

Failed to load resource: vscode-resource:/c%3A/Users/Utente/.vscode/extensions/bierner.markdown-preview-github-styles-0.1.2/base.css
net::ERR_ACCESS_DENIED

Same errors for github-markdown.css and github.css.

mjbvz commented 6 years ago

I can't repo on windows. Can you test this on VS Code insiders as well

Gliptal commented 6 years ago

1.25.0-insider works.

mjbvz commented 6 years ago

Closing this issue as upstream