mjbvz / vscode-github-markdown-preview-style

VS Code extension that changes the built-in markdown preview to match Github's styling
https://marketplace.visualstudio.com/items?itemName=bierner.markdown-preview-github-styles
MIT License
303 stars 57 forks source link

No white bg in body #35

Closed elrumordelaluz closed 5 years ago

elrumordelaluz commented 5 years ago

Is there a reason why after install and activate the extension and opening Open Webvie Developer Tools, the body is:

body {
  background-color: var(--vscode-editor-background);
  /* ... */
}
mjbvz commented 5 years ago

Is this causing an actual error? We should override that rule.

Please provide repo steps or more detail about what is not working

elrumordelaluz commented 5 years ago

There's no evidence of errors, the issue is that after install and activate, the preview remains with the editor background. Following a demo:

markdown

and inspecting

markdown_2

mjbvz commented 5 years ago

It doesn't look the the extension is even loading. In the webview, can you verify that the <link> stylesheet import for this extension is in the head? Also, do you have any other markdown extension installed?

elrumordelaluz commented 5 years ago

no <link> in head and I haven't installed other md-related extensions.

However disabled all extensions and reinstalled Markdown Preview Github Styling but stills the same result.

screen shot 2018-10-23 at 23 13 21

elrumordelaluz commented 5 years ago

[update]

there are <link>s in head but for some reason styles doesn't apply in DOM nodes.

screen shot 2018-10-26 at 21 56 38

body only have styles applied from <style> tag with default editor styles

Gliptal commented 5 years ago

I seem to be having the same problem. No white background, default styling.

mjbvz commented 5 years ago

Likely a duplicate of #40. Do you have files.associations set?

Gliptal commented 5 years ago

Unfortunately I do not.

mjbvz commented 5 years ago

Still, try the next VS Code insiders build. These associations can also come from extensions

elrumordelaluz commented 5 years ago

yup 🎉 that was the issue. I had the following lines in my settings.json

{
  "files.associations": {
    "*.css": "postcss"
  },
}

Removing them solves the issue.

mjbvz commented 5 years ago

Fixed upstream in VS Code