mjbvz / vscode-github-markdown-preview-style

VS Code extension that changes the built-in markdown preview to match Github's styling
https://marketplace.visualstudio.com/items?itemName=bierner.markdown-preview-github-styles
MIT License
303 stars 57 forks source link

Create new extension that bundles together github markdown preview extensions #37

Closed mjbvz closed 5 years ago

mjbvz commented 5 years ago

Problem

This extension only changes the visual style of VS Code's markdown preview. However many users expect that this extension will provide other github flavored markdown features, such as rendering :emoji: or rendering the yaml frontmatter as a table. Extensions for these exist but must be installed separately.

Proposal

I'm in favor or keeping this extension focused on doing one thing: styling the markdown preview. Having one feature per extension lets these features be enabled/disabled individually compared to a monolithic extension.

However most users just want to install a single extension that makes their markdown preview match what they see on github. Therefore, I propose creating a new extension tentatively called Github Markdown Preview that includes this extension plus all the other github related markdown preview extensions. These would be included using extensionDependencies, which would keep the individual extensions small and let them be installed individually if desired

mjbvz commented 5 years ago

Created extension pack here: https://marketplace.visualstudio.com/items?itemName=bierner.github-markdown-preview

Be aware that the purple icon is now used for that extension pack while this extension now has a stylish rainbow variant of the logo: