search

mjbvz / vscode-github-markdown-preview-style

VS Code extension that changes the built-in markdown preview to match Github's styling
https://marketplace.visualstudio.com/items?itemName=bierner.markdown-preview-github-styles
MIT License
303 stars 57 forks source link

Odd bug: "*.css" file association sets markdown style back to default #40

Closed joslarson closed 5 years ago

joslarson commented 5 years ago

I've reproduced this bug on macOS and Windows as explained below.

  1. Disable all extension except for the "Github Markdown Preview" bundle
  2. Remove all custom settings so that your user settings file is as shown below:
{
    "files.associations": {
        "*.css": "scss"
    }
}
  1. Open a markdown file and launch preview

Following these steps you should see that the markdown preview is using VS Code's default styles, not the Github styles.

If you change ".css" to anything else (".csss" or "*.php" for example) the github markdown styling starts working again.

mjbvz commented 5 years ago

Upstream issue https://github.com/Microsoft/vscode/issues/62892

Will move details over

mjbvz commented 5 years ago

@joslarson Thank you for the investigation here. I don't think I would have tracked this down otherwise.

Please try the next VS Code insiders build. It should be fixed in that

joslarson commented 5 years ago

@mjbvz glad I could contribute in some way. It took me a while to figure out that it had something to do with my settings file! Thanks for investigating and creating the patch :)