mjbvz / vscode-github-markdown-preview-style

VS Code extension that changes the built-in markdown preview to match Github's styling
https://marketplace.visualstudio.com/items?itemName=bierner.markdown-preview-github-styles
MIT License
303 stars 57 forks source link

Text color changes to light grey with dark theme #48

Closed BaerMitUmlaut closed 4 years ago

BaerMitUmlaut commented 5 years ago

When you use a dark theme, the text color changes to a light gray and it gets quite unreadable:

grafik

mjbvz commented 5 years ago

I can't repo. What is the markdown source?

Screen Shot 2019-07-01 at 8 33 32 AM
dlferro commented 4 years ago

I have this occurring as well. It appears to occur with all dark themes. In this example I'm using Material Dark. Screen Shot 2020-04-03 at 12 49 25 PM

jckorlian commented 4 years ago

I'm having the same problem, except for me it doesn't matter what theme I'm using. Light or dark theme, official or custom, headers are light grey.

Using Visual Studio Code 1.45.0

dschox commented 4 years ago

same as @jcolsen

mjbvz commented 4 years ago

If you are seeing this recently, it is probably coming from another one of your extensions: https://github.com/Binaryify/OneDark-Pro/issues/391

jckorlian commented 4 years ago

If you are seeing this recently, it is probably coming from another one of your extensions: Binaryify/OneDark-Pro#391

You're right, it's being caused by that theme. I've disabled it until fixed. Thank you!

mjbvz commented 4 years ago

I suspect the original problem reported may also have been caused by another extension or by some custom user styles

Closing but let me know if you find steps to reproduce

lumaxis commented 4 years ago

Looks like the GitHub theme is causing this too

lumaxis commented 4 years ago

Ooh, looking at https://github.com/Binaryify/OneDark-Pro/issues/391, it sounds like what @mjbvz is saying is that simply having One Dark Pro installed causes this? 😳

Binaryify commented 4 years ago

@lumaxis that should already been fixed

jckorlian commented 4 years ago

@lumaxis that should already been fixed

The issue still persists with v3.5.5 for me if that's where the fix is applied.

Binaryify commented 4 years ago

@jcolsen check v3.6.0