Closed nemosmithasf closed 4 years ago
Out of scope for this extension. Automatic switching to a dark mode goes against the spirit of trying to match how GitHub renders markdown
@mjbvz GitHub now has a native dark mode, so maybe it's time to reconsider this? :thinking:
If someone puts together a PR, then sure
@mjbvz I might work on this if I find the time, could you reopen the issue?
I just spent some time looking into this and realized that the extension's CSS actually comes from the github-markdown-css
package which has its own issue for dark mode support. I've subscribed to that issue and will look into this again once/if it's resolved.
Now that VScode supports automatic dark mode adjustment, it would be nice if the plugin can be updated to support the feature as well.