search

mjbvz / vscode-github-markdown-preview-style

VS Code extension that changes the built-in markdown preview to match Github's styling
https://marketplace.visualstudio.com/items?itemName=bierner.markdown-preview-github-styles
MIT License
303 stars 57 forks source link

Respecting Dark Mode configurations #50

Closed nemosmithasf closed 4 years ago

nemosmithasf commented 4 years ago

Now that VScode supports automatic dark mode adjustment, it would be nice if the plugin can be updated to support the feature as well.

mjbvz commented 4 years ago

Out of scope for this extension. Automatic switching to a dark mode goes against the spirit of trying to match how GitHub renders markdown

shroudedcode commented 3 years ago

@mjbvz GitHub now has a native dark mode, so maybe it's time to reconsider this? :thinking:

mjbvz commented 3 years ago

If someone puts together a PR, then sure

shroudedcode commented 3 years ago

@mjbvz I might work on this if I find the time, could you reopen the issue?

shroudedcode commented 3 years ago

I just spent some time looking into this and realized that the extension's CSS actually comes from the github-markdown-css package which has its own issue for dark mode support. I've subscribed to that issue and will look into this again once/if it's resolved.