search

mjbvz / vscode-github-markdown-preview-style

VS Code extension that changes the built-in markdown preview to match Github's styling
https://marketplace.visualstudio.com/items?itemName=bierner.markdown-preview-github-styles
MIT License
303 stars 57 forks source link

Markdown tables with extra lines render when they shouldn't #54

Closed jeankaplansky closed 2 years ago

jeankaplansky commented 4 years ago

image

vs.

image

I can't use the extension if I can't count on rendering fidelity with GitHub.

mjbvz commented 4 years ago

Please share the text of the code along with screenshots

jeankaplansky commented 4 years ago

The text of the code in question is in the screenshot showing the rendered table from the extension preview. I’ll dig out the sha of the previous commit with the specific table today. It’s not difficult to recreate though. Create a table with a blank line between rows. Regular browser rendering fails on a table with an empty line in between table rows.

Thanks!

On Thu, Jul 16, 2020 at 7:00 PM Matt Bierner notifications@github.com wrote:

Please share the text of the code along with screenshots

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mjbvz/vscode-github-markdown-preview-style/issues/54#issuecomment-659721870, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA63KBZ3SQP3R2YFYZTUTPDR36BBHANCNFSM4O4SJBZA .

--

Jean Kaplansky | Technical Writer | 518-930-1068

Deque Systems - Accessibility for Good

deque.com

mjbvz commented 2 years ago

Again, please always share the text of the code along with screenshots

mjbvz commented 2 years ago

Closing as not quickly testable without simple code to copy and paste