Closed usernamehw closed 2 years ago
Oh, this would be soooo good.
Want to submit a PR? Seems silly to have two extensions for GitHub styling
I absolutely agree, but that other extension is a hack that I threw together. (I edited in node-modules
!)
I think it's better to wait until Sindre and Hyrious have okayed the upstream issue: sindresorhus/github-markdown-css#76
Afterwards, ozaki's extension could switch to dark-only to differentiate from this extension (I am checking with ozaki as to whether the extension was meant to be dark-only in the first place)
Yeah Ozaki's extension is dark only. I would suggest to get a fork of https://github.com/hyrious/github-markdown-css/tree/785253e running and help them add a Puppeteer "used CSS" coverage filter.
I got this working at https://github.com/OzakIOne/markdown-github-dark/tree/8e173b6
https://marketplace.visualstudio.com/items?itemName=ozaki.markdown-github-dark
Please, do send a PR. The more people working in the same place, the better.
I'm a little confused about all this comments and links. Can anyone tell me in on paragraph where this idea is going? It seems to be there's a lot of people and projects involves, and pulling cords from different places.
I personally feel that this extension should be able to build automatically..
If sindresorhus/github-markdown-css#76 is not addressed, the extension will require edits to node_modules
which is bad juju
PR just opened! 😆
Dark dimmed would require me to generate themes. And there's little benefit as there is no corresponding container class in Visual Studio Code.
I want a high-contrast theme but it would take much development time so lets put it on the bakcburner.
How do people feel about a dark-only or light-only switch on this extension?
This exists on the marketplace already, but Matt's interested in shipping these with the extension.
React with 👍🏾
if you feel it's useful; react with 👎🏾
if you feel its unneeded.
It would make sense if it was an enum with 3 options:
1) Depending on the current theme workbench.colorTheme
(if theme is dark - preview is dark, if light - preview is light)
2) Dark
3) Light
So being able to switch it through a menu action isn't necessary in your opinion?
GitHub now has official support for 2 themes:
Having at least one of them implemented in this extension (and used if active theme is dark) would be great.