search

mjbvz / vscode-github-markdown-preview-style

VS Code extension that changes the built-in markdown preview to match Github's styling
https://marketplace.visualstudio.com/items?itemName=bierner.markdown-preview-github-styles
MIT License
303 stars 57 forks source link

Tasks list items within <details> tags do not render correctly #66

Closed weaversam8 closed 3 years ago

weaversam8 commented 3 years ago

When rending markdown like this:

<details open>
<summary>Click here to open / close the details view</summary>

- [ ] Task list item
- [ ] Task list item no 2
    - [ ] Task list indented

</details>

It should render like this:

Click here to open / close the details view - [ ] Task list item - [ ] Task list item no 2 - [ ] Task list indented

But it actually renders like this:

An image displaying the error described. The "details" element renders correctly, showing a triangle button to open or close the expandable section, but within the expanded section, the task list does not render correctly. It renders as a regular list with bullets instead of checkboxes.

mjbvz commented 3 years ago

This repo only provides styling, not task list support

Try https://marketplace.visualstudio.com/items?itemName=bierner.github-markdown-preview

weaversam8 commented 3 years ago

I'm now unable to reproduce this issue, but I only had this extension installed, not the other extensions in the pack.

I believe task list support is provided by VS Code's markdown preview renderer, rather than bierner.markdown-checkbox. We can consider this resolved. If there's another issue, I'll open it with microsoft/vscode.

mjbvz commented 3 years ago

Great! but just a note that tasklist support does come from extensions and not VS Code itself (I maintain VS Code's builtin markdown preview so I'm pretty confident on this :)

If you see any issues with tasklists, please file them against the extensions