Fix Open quote highlighting

mjbvz / vscode-lit-html

Adds syntax highlighting for html inside of JavaScript and TypeScript tagged template strings

https://marketplace.visualstudio.com/items?itemName=bierner.lit-html

MIT License

318 stars 75 forks source link

Fix Open quote highlighting #74

Closed kufii closed 5 years ago

kufii commented 5 years ago

some color themes use different colors for the quote than the contents, and the open quote wasn't being highlighted properly. See Screenshot:

issue

Notice how it's green instead of blue? This PR fixes this

kufii commented 5 years ago

tbh I think travis is wrong for the same reason by failing this, can someone correct me if I'm wrong? I don't think the CI should fail this

mjbvz commented 5 years ago

Change looks reasonable.

This repo has some baseline tests for the lit-html grammar. It looks like this change caused travis to fail. Try running npm test locally. It should probably change one of the grammar baseline file. Please include that changed file in the PR too.

kufii commented 5 years ago

worked for OS X, failed for linux for some reason. Any ideas?

kufii commented 5 years ago

@mjbvz just pinging you incase you didn't see, no rush though

mjbvz commented 5 years ago

Thanks! Merging since the failure seems unrelated. Will fix that