search

mjbvz / vscode-markdown-emoji

VS Code extension that adds support for :emoji: syntax to the built-in markdown preview
https://marketplace.visualstudio.com/items?itemName=bierner.markdown-emoji
MIT License
96 stars 17 forks source link

Emojis don't render in the preview window inside <table>'s as they do on GitHub. #16

Closed MrMattBusby closed 2 years ago

MrMattBusby commented 2 years ago

Could be by design? This following code does not display the same inside the <table> between VS Code and GitHub:

:smile:

:smile:
:smile: 
<table>
  <thead>
    <tr>
      <th>:smile:</th>
    </tr>
  </thead>
  <tbody>
    <tr>
      <td>:smile:</td>
    </tr>
  </tbody>
</table>
:smile:

:smile:

:smile:
:smile:
:smile:
:smile:
mjbvz commented 2 years ago

A bit hard to tell what the issue is but yes, generally Markdown syntax no longer applies inside of html elements so this seems to be by-design

kema-dev commented 2 years ago

GitHub renders emojis even inside of HTML elements, and markdown-it-emoji does it too (you can test here). Is it possible add an option to render them inside ? I've never coded an extension but I could try to make a a PR with a little help