search

mjbvz / vscode-markdown-emoji

VS Code extension that adds support for :emoji: syntax to the built-in markdown preview
https://marketplace.visualstudio.com/items?itemName=bierner.markdown-emoji
MIT License
96 stars 17 forks source link

[bug]some emoji can't display in my vscode markdown preview #5

Closed victorting closed 2 years ago

victorting commented 5 years ago

image image image image image image image

there is still a lot of emoji can't display properly, can someone help fix it? thanks!!!

FredHappyface commented 4 years ago

Just to follow this up.

Looks like the flags now have icons

However there are still a few below that do not.

:u6708: | :u6708: | :u6709: | :u6709: |   :u6307: | :u6307: | :u5272: | :u5272: | :u7121: | :u7121: |   :u7981: | :u7981: | :u7533: | :u7533: | :u5408: | :u5408: |   :u7a7a: | :u7a7a: |
:u55b6: | :u55b6:

:atom: | :atom: | :basecamp: | :basecamp: |   :basecampy: | :basecampy: | :bowtie: | :bowtie: |   :electron: | :electron: | :feelsgood: | :feelsgood: |   :finnadie: | :finnadie: | :goberserk: | :goberserk: |   :godmode: | :godmode: | hurtrealbad: | :hurtrealbad: |
:neckbeard: | :neckbeard: | :octocat: | :octocat: |   :rage1: | :rage1: | rage2: | :rage2: |   :rage3: | :rage3: | rage4: | :rage4: |   :shipit: | :shipit:  | :suspect: | :suspect: |   :trollface: | :trollface:

Thanks for a great plugin :smile:

FredHappyface commented 4 years ago

I think this is an issue upstream (markdown-it-emoji)

victorting commented 4 years ago

I think this is an issue upstream (markdown-it-emoji) yes, it is, I found markdown-it-emoji is stopped updating already lasting 4 years

vasilii-kovalev commented 4 years ago

:octocat: emoji doesn't work.

image

Markdown Emoji extension version: 0.0.9 VS Code version: 1.47.2

yeyeto2788 commented 4 years ago

@mjbvz seems like there was a new commit on the markdown-it-emoji dependency that might fix the issue https://github.com/markdown-it/markdown-it-emoji/commit/339abf72f84a02e66fe9a4d682a7217d1f660e6a and help on getting the latest emojis from GitHub.

@vasilii-kovalev seems like octocat is not part of the library https://github.com/markdown-it/markdown-it-emoji/blob/master/lib/data/full.json or at least I don't see it.

yzy1996 commented 3 years ago

About why not support :octocat: :octocat:

see link

mjbvz commented 3 years ago

Please test the new update, which includes markdown-it-emoji 2.0 . Keep in mind that your operating system must also support displaying the emoji in the first place

Also, as the other comments we note, we only support standard emoji. :atom:, :octocat:, and :shipit: are GitHub specific. Please open a separate issue if you'd like to see support for those

mjbvz commented 2 years ago

Closing based on the above comment. Likely not related to this extension (actual emoji rendering is up to your OS / VS Code)