search

mjbvz / vscode-markdown-mermaid

Adds Mermaid diagram and flowchart support to VS Code's builtin markdown preview
https://marketplace.visualstudio.com/items?itemName=bierner.markdown-mermaid
MIT License
648 stars 119 forks source link

Big gap before / after diagram when scaling to fit editor's width #109

Closed bcardiff closed 3 years ago

bcardiff commented 3 years ago

I noticed the preview has a fixed height for diagrams

3JgrvKPYyq

that seems good for small / medium diagrams, but when the content is wide the gap starts to be a problem (unless you have a ultra wide monitor 😅 )

wcwaG5q5fD

The scaling to fit editor's width is a nice feature. Maybe keeping a fixed height was on purpose, i don't know. Would it make sense to remove that gap and allow diagram's height to change as needed?

Thanks for this plugin! 💙

bobatsar commented 3 years ago

I have the same problem, seems to be already in mermaid not in this plugin. https://github.com/mermaid-js/mermaid/issues/1984

bcardiff commented 3 years ago

Thanks! Closing then since is in mermaidjs and not in this repo.