mjbvz / vscode-markdown-mermaid

Adds Mermaid diagram and flowchart support to VS Code's builtin markdown preview
https://marketplace.visualstudio.com/items?itemName=bierner.markdown-mermaid
MIT License
640 stars 115 forks source link

GitGraph id and type are not working at 'merge' #145

Closed JGT90 closed 1 year ago

JGT90 commented 1 year ago

When I try to add an ID or a type to the merge bubble, the graph vanishes.

e.g. merge feature tag: "blubb" - works merge feature id: "blubb" - does not work merge feature type: REVERSE - does not work

justindbaur commented 1 year ago

Also having this issue.

baxterjo commented 1 year ago

Seeing this as well

mjbvz commented 1 year ago

Please share the text of a diagram that demonstrates this problem

JGT90 commented 1 year ago
    gitGraph
        commit
        branch feature
        checkout feature
        commit id:"part1"
        commit id:"part2"
        checkout main
        merge feature tag:"Blubb"
    gitGraph
        commit
        branch feature
        checkout feature
        commit id:"part1"
        commit id:"part2"
        checkout main
        merge feature id:"Blubb"
    gitGraph
        commit
        branch feature
        checkout feature
        commit id:"part1"
        commit id:"part2"
        checkout main
        merge feature type:"Blubb"
mjbvz commented 1 year ago

Thanks @JGT90

The first example now should render properly

The second example seems invalid as it produces an error even on the mermaid playground

Let me know if there are any additional cases that aren't working as expected