search

mjbvz / vscode-markdown-mermaid

Adds Mermaid diagram and flowchart support to VS Code's builtin markdown preview
https://marketplace.visualstudio.com/items?itemName=bierner.markdown-mermaid
MIT License
640 stars 115 forks source link

fix: support keyword`graph` #150

Closed taoqf closed 1 year ago

taoqf commented 1 year ago

Mark graph as code block, too.

mjbvz commented 1 year ago

Please explain this PR. Share link to where graph is supported

taoqf commented 1 year ago

The markdown document will be used in https://e.coding.net/ and https://note.youdao.com/ , and sadly https://e.coding.net/ doesn't support marmaid but only graph

mjbvz commented 1 year ago

From those links I'm not convinced that graph is widely enough used for mermaid, and I am also concerned that it could interfere with other markdown languages. Why wouldn't the bug be on those sites to support the mermaid language identifier instead?

Maybe this could be enabled with a setting, but again I'd need more proof that this would benifit many uses

taoqf commented 1 year ago

I wish those sites could support mermaid, but I cannot change that. like I could not publish this extension neither. I add the setting and create a new pr https://github.com/mjbvz/vscode-markdown-mermaid/pull/154 already. I really wish that will be merged. I will be very grateful for that.