mjbvz / vscode-markdown-mermaid

Adds Mermaid diagram and flowchart support to VS Code's builtin markdown preview
https://marketplace.visualstudio.com/items?itemName=bierner.markdown-mermaid
MIT License
640 stars 115 forks source link

Mermaid diagrams of type mindmap are not rendered #153

Closed bentolor closed 1 year ago

bentolor commented 1 year ago

Hi @mjbvz - Thanks for your extension!

Mermaid now also supports mindmaps, a feature originally requested in #59 .

Unfortunately vscode-markdown-mermaid doesn't seem to render mindmap mermaid diagrams ight now, while gitGraph works.

Is it just a missing mermaid dependency update?

bentolor commented 1 year ago

Okay - I just see it's really brand-new. Only 17 days old. Sorry - wasn't aware on that. https://github.com/mermaid-js/mermaid/releases/tag/v9.2.0

mjbvz commented 1 year ago

Picking up mermaid 9.2.2 however it looks like mindmap support is shipped as an additional dependency

awhitford-cip commented 1 year ago

I thought that since Mermaid was upgraded to 9.3.0 it would be included, but I am getting this error:

No diagram type detected for text: mindmap
isaacsanders commented 1 year ago

I think this last step is still needed: https://mermaid.js.org/syntax/mindmap.html#integrating-with-your-library-website

isaacsanders commented 1 year ago

I made a PR that might get this over the finish line: https://github.com/mjbvz/vscode-markdown-mermaid/pull/174

gs-rickchristy commented 1 year ago

Would really appreciate this.

gogza commented 1 year ago

Just discovered I need this too.

LiangWei88 commented 1 year ago

I think the 9.4.0 is ok? I need this too

gozes commented 1 year ago

I need this too. Hopefully we can get 9.4.0 soon?

gozes commented 1 year ago

I'm not a js/TS person, however, I have opened a PR to bump the version to 9.4.0

mjbvz commented 1 year ago

Actually still broken after #183

Screenshot 2023-03-06 at 1 27 54 PM

Maybe needs changes from #184 too

mjbvz commented 1 year ago

Should work now in 1.17.5 which was just published . Let me know if you notice any issues

gozes commented 1 year ago

@mjbvz I'm seeing

Loading chunk 366 failed.
(error: https://file+.vscode-resource.vscode-cdn.net/Users/jsmontalvo/.vscode/extensions/bierner.markdown-mermaid-1.17.5/dist-preview/366.bundle.js)

using the example from the mermaid site

mindmap
  root((stmory))
    Origins
      Long history
      ::icon(fa fa-book)
      Popularisation
        British popular psychology author Tony Buzan
    Research
      On effectivness<br/>and features
      On Automatic creation
        Uses
            Creative techniques
            Strategic planning
            Argument mapping
                Test
                    Eee
    Tools
      Pen and paper
      Mermaid
mjbvz commented 1 year ago

Hm works fine for me with the official extension build:

Screenshot 2023-03-07 at 8 23 55 AM

Can you please open a new issue with your OS and VS Code version info

isaacsanders commented 1 year ago

This bundle 366 appears to be insecurely supplied to vscode

mjbvz commented 1 year ago

The file is part of the extension bundle:

Screenshot 2023-03-07 at 11 34 39 AM

Can you please open an issue with your OS and VS Code version info

isaacsanders commented 1 year ago

It works if I turn off my security settings.

isaacsanders commented 1 year ago

1.17.7 works beautifully for me.

fh2levelgh commented 1 year ago

It works if I turn off my security settings.

What security settings did you have to change?