search

mjbvz / vscode-markdown-mermaid

Adds Mermaid diagram and flowchart support to VS Code's builtin markdown preview
https://marketplace.visualstudio.com/items?itemName=bierner.markdown-mermaid
MIT License
640 stars 115 forks source link

Subgraph links don't display with Mermaid 9.16. Upgrade to 9.22 #156

Closed andar1an closed 1 year ago

andar1an commented 1 year ago

Is it possible to update the version from 9.16 -> 9.22? Trying to use subgraph connections, and they don't work with 9.16. I have seen posts that state the beta version supports subgraph connections, but Mermaid's official docs show subgraph connections so I believe 9.22 will suffice.

piranna commented 1 year ago

I just came to ask for the same :-) Can we get an update of the mermaid dependency? Is there any way to use a custom patched extension with it, the same way you can use a git dependency on npm?

andar1an commented 1 year ago

GitHub itself will also need to upgrade, learned that after this.

piranna commented 1 year ago

GitHub itself will also need to upgrade, learned that after this.

Yes, in fact Github version is older, but at least this can help to debug it easier until they fix it.

andar1an commented 1 year ago

Agreed, I have been copy and pasting into mermaid live which is a bit tedious lol

piranna commented 1 year ago

Maybe better error messages would be nice, but that's an issue of mermaid itself.

mjbvz commented 1 year ago

Fixed by 1.15.3. In the future, please consider submitting a PR for mermaid version bumps as it's pretty straightforward

andar1an commented 1 year ago

Fixed by 1.15.3. In the future, please consider submitting a PR for mermaid version bumps as it's pretty straightforward

Good to know, will do.

piranna commented 1 year ago

In the future, please consider submitting a PR for mermaid version bumps as it's pretty straightforward

Agree on that.