mjbvz / vscode-markdown-mermaid

Adds Mermaid diagram and flowchart support to VS Code's builtin markdown preview
https://marketplace.visualstudio.com/items?itemName=bierner.markdown-mermaid
MIT License
657 stars 120 forks source link

Images not being rendered since 1.15.3 #166

Closed thattanmay closed 1 year ago

thattanmay commented 1 year ago
img

Since the Dec releases, images are not being rendered via the HTML syntax, reverting back to 1.15.2 works fine.

mjbvz commented 1 year ago

Please share steps to reproduce this (including the chart code as text)

thattanmay commented 1 year ago

Apologies for late reply, please find the code below to reproduce:

graph TD

IRON_PLATE(( <img src='https://wiki.factorio.com/images/thumb/Iron_plate.png/32px-Iron_plate.png' /> ))
IRON_ORE(( <img src='https://wiki.factorio.com/images/thumb/Iron_ore.png/32px-Iron_ore.png' /> ))

IRON_ORE --> IRON_PLATE

version: 1.15.2

1 15 2

version: 1.17.3(latest)

1 17 3(latest)

in the earlier version I'm able to render images as nodes from URL, in the newer version this functionality is broken

mjbvz commented 1 year ago

Our rendering seems to match the rendering from mermaid's live editor with mermaid 9.3

If this seems like an mermaid issue, please file this against them