mjbvz / vscode-markdown-mermaid

Adds Mermaid diagram and flowchart support to VS Code's builtin markdown preview
https://marketplace.visualstudio.com/items?itemName=bierner.markdown-mermaid
MIT License
657 stars 120 forks source link

Bump Mermaid version to 10.0.0 #177

Closed shtratos closed 1 year ago

shtratos commented 1 year ago

Mermaid version 10.0.0 is the latest, but it has some breaking API changes.

I had to change the mermaid.render call as it no longer accepts a callback. see https://github.com/mermaid-js/mermaid/blob/master/CHANGELOG.md#1000

N.B. I tested the rendering and it works for correct graph, but it does not render parsing errors. I'm very new to node.js, so not sure if my changes are correct. Any pointers on how to fix this would be appreciated.

Also:

shtratos commented 1 year ago

I've been seeing this issue in the logs, let's see if the fix helps https://github.com/mermaid-js/mermaid/issues/4140

shtratos commented 1 year ago

Closing in favour of #184