search

mjbvz / vscode-markdown-mermaid

Adds Mermaid diagram and flowchart support to VS Code's builtin markdown preview
https://marketplace.visualstudio.com/items?itemName=bierner.markdown-mermaid
MIT License
633 stars 114 forks source link

v1.18.1 breaks when graph node has comments on same line #196

Closed martincook3 closed 1 year ago

martincook3 commented 1 year ago

The following markdown renders correctly in v1.18.0:

``` mermaid
graph TD

Node1 --- Node2  %% comment
However, in v1.18.1 it gives 

```text
> Parse error on line 3:
> Parse error on line 3:
> ...DNode1 --- Node2  %% comment %%
> ---------------------^
> Expecting 'SEMI', 'NEWLINE', 'SPACE', 'EOF', 'AMP', 'ALPHA', 'COLON', 'START_LINK', 'LINK', 'DOWN', 'DEFAULT', 'NUM', 'COMMA', 'MINUS', 'BRKT', 'DOT', 'PUNCTUATION', 'UNICODE_TEXT', 'PLUS', 'EQUALS', 'MULT', 'UNDERSCORE', got 'PCT'

VSCode info: Version: 1.77.3 (user setup) Commit: 704ed70d4fd1c6bd6342c436f1ede30d1cff4710 Date: 2023-04-12T09:16:02.548Z Electron: 19.1.11 Chromium: 102.0.5005.196 Node.js: 16.14.2 V8: 10.2.154.26-electron.0 OS: Windows_NT x64 10.0.19045 Sandboxed: No

martincook3 commented 1 year ago

It seems to be an issue with Mermaid 10.1.0 itself, not your extension. Sorry. Closing the issue.