mjbvz / vscode-markdown-mermaid

Adds Mermaid diagram and flowchart support to VS Code's builtin markdown preview
https://marketplace.visualstudio.com/items?itemName=bierner.markdown-mermaid
MIT License
656 stars 120 forks source link

Multi-line `.HTML` comment, in numbered list, after Mermaid section, breaks rendering. #242

Closed RokeJulianLockhart closed 8 months ago

RokeJulianLockhart commented 8 months ago

Try

::: mermaid
flowchart
    n1["Rectangle"]

:::

1.  **Test**

    <!--

    test -->

This was the absolute minimum I could create which would still break the renderer, per

image

To demonstrate,

  1. ::: mermaid
    flowchart
        n1["Rectangle"]
    
    :::
    
    <!--
    
    test -->

    and

  2. ::: mermaid
    flowchart
        n1["Rectangle"]
    
    :::
    
    1.  **Test**
    

in contrast, render correctly.

mjbvz commented 8 months ago

Seems ok to me

Image

What about with other extensions disabled?

RokeJulianLockhart commented 8 months ago

https://github.com/mjbvz/vscode-markdown-mermaid/issues/242#issuecomment-1928637670

I swear, whatever extension is causing this mayhem I will nuke from orbit, @mjbvz.

RokeJulianLockhart commented 4 months ago

https://github.com/mjbvz/vscode-markdown-mermaid/issues/242#issuecomment-1928637670

@mjbvz, I'm still seeing this, using

```mermaid
flowchart
    n1["Rectangle"]

```

1.  **Test**

    <!--

    test -->

but not the aforementioned working versions

```mermaid
flowchart
    n1["Rectangle"]

```

<!--

test -->
```mermaid
flowchart
    n1["Rectangle"]

```

1.  **Test**

Screencast_20240524_222230.webm

Do you have a solution for https://github.com/microsoft/vscode/issues/81950#issue-502557730? I have a lot of extensions (albeit few which should affect anything like this).