mjbvz / vscode-markdown-shiki

Uses Shiki for VS Code's built-in markdown preview syntax highlighting
https://marketplace.visualstudio.com/items?itemName=bierner.markdown-Shiki
MIT License
19 stars 6 forks source link

Power Query highlighting #19

Closed UWE-BIDEV closed 1 year ago

UWE-BIDEV commented 1 year ago

Power Query highlighting doesn't seem to work. Am I doing something wrong? Thanks

UWE-BIDEV commented 1 year ago

I understand that this is because the extension is using an older version of shiki? I downloaded the powerquery.tmlLanguage json file from the link below https://github.com/shikijs/shiki/tree/main/packages/shiki/languages

Then I dropped it in the vscode extension folder below C:\Users[username].vscode\extensions\bierner.markdown-shiki-0.1.1\node_modules\shiki-languages\data\grammars

But still no luck! What else do I need to do? Many thanks

UWE-BIDEV commented 1 year ago

I've now gone through all the files in my local copy of the extension folder and added powerquery / pq wherever appropriate (following the example of python) C:\Users[username].vscode\extensions\bierner.markdown-shiki-0.1.1\ That seemed to do the trick! 😊

@mjbvz -How much work would it take, if I wanted to update shiki in the extension so it's available to all on the VS Code marketplace? I'm not sure where to start...