search

mjdescy / TodoTxtMac

TodoTxtMac is a minimalist, keyboard-driven to-do manager for Mac OS X (10.8 Mountain Lion and higher) that conforms to the todo.txt format spec.
Other
242 stars 40 forks source link

Can't add tasks or open lists with custom region settings #108

Closed antonlarin closed 8 years ago

antonlarin commented 8 years ago

I customized time representation through System Preferences on my system and that apparently doesn't work well with TodoTxtMac. The app doesn't add tasks (pressing Enter simply removes focus from TextArea) and it doesn't open existing lists. To be more specific, I'm using the preset for Russian region but with 12-hour time format (default is 24-hour).

I used the debugger and found out that NSDateFormatter fails to parse the fake due date and returns nil here which then it's being used here, causing the exception. Adding [dateFormatter setLocale:[NSLocale systemLocale]]; after that line seems to fix the issues that I'm experiencing, but I don't know whether that could be considered a solution.

mjdescy commented 8 years ago

@antonlarin Thank you for this bug report. I was wondering when locale-related bugs would surface.

I will look into your proposed solution and try to see if it has any unintended consequences. Thanks for being so thorough.

mjdescy commented 8 years ago

@antonlarin Try version 2.2.2. It should fix your bug.

antonlarin commented 8 years ago

That was really quick, thank you.