mje-nz / natnet_ros

NatNet 3 ROS driver
BSD 3-Clause "New" or "Revised" License
19 stars 9 forks source link

Fix logger for Melodic #6

Closed felixvd closed 5 years ago

felixvd commented 5 years ago

Something with the bound method caused an error when running this package in Melodic, as reported in #5 . This seems to work as far as we can tell, and should work in earlier versions of ROS and Python.

Fixes #5

codecov[bot] commented 5 years ago

Codecov Report

Merging #6 into master will decrease coverage by 1.6%. The diff coverage is 70%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master      #6     +/-   ##
========================================
- Coverage      90%   88.4%   -1.6%     
========================================
  Files           1       1             
  Lines         150     155      +5     
========================================
+ Hits          135     137      +2     
- Misses         15      18      +3
Impacted Files Coverage Δ
natnet_ros/scripts/client 88.4% <70%> (-1.6%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a859ada...d67e70d. Read the comment docs.

mje-nz commented 5 years ago

Thanks for the contribution! There should be a fix for this in the dev branch already, would you mind checking if it works for you?

felixvd commented 5 years ago

I'm sure that will work. Should've thought to check for other branches. Cheers!

mje-nz commented 5 years ago

No worries, I've been a bit slack maintaining this lately and there's quite a bit sitting unmerged. Don't hesitate to raise an issue if you come across anything else :)