mjeanroy / rollup-plugin-license

Rollup plugin to add license banner to the final bundle and output third party licenses
MIT License
111 stars 21 forks source link

Deprecated dependencies not getting updated #1738

Closed cotes2020 closed 4 months ago

cotes2020 commented 4 months ago

Hi there, my project uses the latest rollup-plugin-license (v3.4.0), and when I ran npm install, I got the warning:

npm warn deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported

It seems that the major version of glob is deprecated, out of curiosity I cloned this repository and checked the deprecation of all the dependencies and the result is as follows:

Upgrading ~/rollup-plugin-license/package.json
[====================] 38/38 100%

 @typescript-eslint/eslint-plugin   7.11.0  →    7.12.0
 @typescript-eslint/parser          7.11.0  →    7.12.0
 eslint                             8.57.0  →     9.4.0
 glob                               ~7.2.0  →   ~10.4.1
 jasmine                            3.10.0  →     5.1.0
 jasmine-core                       3.10.1  →     5.1.2
 magic-string                      ~0.30.0  →  ~0.30.10
 mkdirp                             ~3.0.0  →    ~3.0.1
 package-name-regex                 ~2.0.6  →    ~4.0.0
 prettier                            3.2.5  →     3.3.0

Screenshot 2024-06-04 at 02 26 20

As you can see, the major versions of 5 of these packages are far behind (in red in the image), so they desperately need to be updated. If you have a specific reason for keeping the older versions, can you share why?

BTW, I noticed that this repository has dependabot installed, but it doesn't seem to be working very well, maybe you should consider improving the dependabot configuration?

Thanks for keeping up this excellent project!


Update:

If you don't mind, I can create a PR to help you fix the dependabot configuration.

mjeanroy commented 4 months ago

Hi,

Your reports mentioned some devDependencies, which should not impact you as these dependencies should not be installed on your project.

Among "dependencies" (not devDependencies):

If you don't mind, I can create a PR to help you fix the dependabot configuration.

No thanks, I only need to re-check how to upgrade glob & package-name-regex.

cotes2020 commented 4 months ago

Ok, got it, thanks for the detailed reply :)