Closed yume-chan closed 3 months ago
Hi @yume-chan, Many thanks for the report! I just published v3.5.1 which should solved the issue.
I don't really understand the code. It seems like you want to search for license/licence files in dir, but why did you do a deep search starting from cwd?
You're right, it was unnecessarily complicated, I took this fix as an opportunity to simplify (see here).
Let me know if something does not work as expected, I'll publish a patch as quickly as possible!
Thanks for your super quick response!
I have verified v3.5.1 works in my project and has good performance!
@mjeanroy would you mind also looking into why it's not generating the license text for https://github.com/jakearchibald/idb-keyval? I did some digging but couldn't figure out why. Thanks :)
Hi @Keavon,
Thank you very much for your report.
It appears files named LICENCE
(LICENSE
files were ok) were not detected anymore because the same fdir
was re-used inappropriately, I'm very sorry for that.
It should be fixed in v3.5.3, please let me know if it's not the case.
Thank you for the very prompt fix, @mjeanroy! Yes, I can confirm this solves the issue.
After upgrading to 3.5.0, I noticed that it no longer writes license text from dependencies.
Here is a minimal repro: https://github.com/yume-chan/license-test
It currently has
rollup-plugin-license@3.4.1
, if you runpnpm i
thenpnpm build
in thefoo
folder, the outputlib/license.txt
is:But if I upgrade
rollup-plugin-license
to3.5.0
, the output becomes:In my simple investigation,
fdir
added in #1742 didn't resolve the symlink innode_modules
folder.I tried something like
It works in the minimal repro, but it's so slow in a real project that it never finishes after several minutes.
I don't really understand the code. It seems like you want to search for
license
/licence
files indir
, but why did you do a deep search starting fromcwd
?