search

mjeanroy / rollup-plugin-license

Rollup plugin to add license banner to the final bundle and output third party licenses
MIT License
105 stars 21 forks source link

Regression in v3.5.1 #1753

Open fisker opened 6 days ago

fisker commented 6 days ago

Thanks for the great work here.

Prettier is using this plugin, when upgrading to v3.5.1, I found that licences from emoji-regex, ignore, and postcss-selector-parser are not discovered.

After some investigation, I found their license are named LICENSE-MIT.

Reading this line https://github.com/mjeanroy/rollup-plugin-license/blob/c905ef6ec861511490a2dc8083f33564939e8bea/src/license-plugin.js#L205, it seems they are not intentionally to be found... Anyway, obviously they are licenses, I don't want remove them now, so should we found LICENSE-MIT(maybe other people use LICENSE-*?) file by default? Or should we make the filenames configurable?

bluwy commented 5 days ago

I noticed this is happening in Vite for cssesc and postcss-selector-parser too. cssesc is a little unique with LICENSE-MIT.txt