search

mjec / rc-niceties

End of batch niceties for the Recurse Center
MIT License
15 stars 5 forks source link

Remove hard-coded "special" people #59

Closed jasonaowen closed 3 years ago

jasonaowen commented 3 years ago

The Niceties app's concept of "special" people is based on an out-of-date assumption: that we should only show faculty members that are leaving soon. Since the staff stopped using the Niceties app, they've been including all faculty members in the Google form.

(It is also based on the assumption that the RC API would not give departing faculty members' end date; I'm not sure if that is still the case.)

We want Niceties to always show faculty, and we started doing so in commit PR #30. That PR also commented out the client-side handling of "special" people, so even if we were populating that field in the API, the client would not show it.

Remove the "special" field in the API, delete the commented-out front-end code that used it, and clean up the front-end code around displaying faculty.

jasonaowen commented 3 years ago

Thank you for splitting that request out into https://github.com/mjec/rc-niceties/issues/67 !