search

mjec / rc-niceties

End of batch niceties for the Recurse Center
MIT License
15 stars 5 forks source link

convert Person to ES6 #81

Closed christalee closed 3 years ago

christalee commented 3 years ago

This commit converts Person to use ES6 classes instead of React.createClass, a pre-requisite for migrating from React 15 to 16. It uses constructor, a JS builtin, to create the initial state - I'm not 100% sure that's the right way to go and would appreciate feedback on that. Otherwise the function body is nearly unchanged, except for a simplification of Checkbox state in render.

christalee commented 3 years ago

I squashed the commits (including the changes) but I'm unimpressed with the fragmented diff. Is this because of whitespace issues? I didn't think I introduced any changes but maybe I did.

christalee commented 3 years ago

I made some whitespace-only commits, and the diff is much more readable now! Sorry I didn't get it together to figure that out before I asked for your review. I'll go ahead and merge.