mjemmeson / Date-Holidays-GB

Other
4 stars 1 forks source link

Needs to document that this does not include local Scottish bank holidays #22

Open robrwo opened 1 year ago

robrwo commented 1 year ago

In Scotland, local councils have the power to set their own bank holidays, and traditionally they do this on different days so that people can travel to a neighbouring council for shopping etc.

See https://www.mygov.scot/scotland-bank-holidays and for example https://www.edinburgh.gov.uk/council-democracy/public-holidays/2 vs https://www.angus.gov.uk/council_and_democracy/council_information/public_holidays_2023

I don't think there is a consistent, downloadable source that you can include. So I would suggest adding a note that this list does not include these holidays.

peternewman commented 1 year ago

In Scotland, local councils have the power to set their own bank holidays, See https://www.mygov.scot/scotland-bank-holidays

Pedantically, from the first website you linked to, they are public holidays, but not bank holidays:

Each local council in Scotland has powers to make certain days 'local' public holidays. Bank holidays are the same across Scotland.

So any note added could be worded to clarify the differences and explain which will and won't be included.

for example https://www.edinburgh.gov.uk/council-democracy/public-holidays/2 vs https://www.angus.gov.uk/council_and_democracy/council_information/public_holidays_2023

The worst case seems to be the PDFs here 😢: https://www.inverclyde.gov.uk/council-and-government/council-public-holidays

I don't think there is a consistent, downloadable source that you can include. So I would suggest adding a note that this list does not include these holidays.

robrwo commented 1 year ago

I was using the colloquial "bank holiday" and "public holiday" as the same thing. My error. But I don't think a note about local Scottish holidays needs to clarify that.

My point was mainly that there are separate local public holidays in Scotland that are not included, and for practical reasons cannot be.

Edit: the practical reasons being that they are not always available in a consistent machine-readable format, and that they may be ad hoc dates with no consistent rules, or unusual rules (If I recall, one of the councils has a holiday that is traditionally second-to-last Monday of the month, but this can brake some calendar software.)