search

mjendruk / mammut

Highspeed-Gravity Racer for Game Programmig Course at HPI
Other
4 stars 0 forks source link

Cave cleanup #73

Closed karyon closed 10 years ago

karyon commented 10 years ago

should fix #66.

mjendruk commented 10 years ago

hm, this does not seem to work… screen shot 2014-03-07 at 23 24 21

karyon commented 10 years ago

please try again. and don't ask how i missed this...

mjendruk commented 10 years ago

In some cases you can still look through the cave. Could you change it? For example make the "collision radius" smaller than the average cave radius and move the cave a little bit more to +z?

screen shot 2014-03-11 at 21 48 28 screen shot 2014-03-11 at 21 50 59

karyon commented 10 years ago

is that right at the beginning or right before dying?

the former will be fixed by a a followup PR that moves the cave a little bit towards z.

the latter... yes, we should probably lower the collision radius, probably by the maximum xy-length of the random offset vectors used in the cave. i'll do this in the followup PR.

mjendruk commented 10 years ago

you are right. but why do this in a follow-up pr?

karyon commented 10 years ago

i just noticed that the beginning should already be fixed by this PR, please tell me if that's not true.

mjendruk commented 10 years ago

no it's still there. you have to try hard to see it and it isn't always visible. screen shot 2014-03-13 at 00 42 44

carolinfiedler commented 10 years ago

it’s still there (in commit 6c0dd9210) mammut_cave

lowering the collision radius should be part of this PR (not a follow-PR) i can’t reproduce it, but with high speed it was possible to see the »universe« before dying

carolinfiedler commented 10 years ago

is this an error in the cave? it’s real black (no dark red or something)

mammut_cave2

karyon commented 10 years ago

ok, now at the beginning one shouldn't see the beginning of the cave anymore.

i also lowered the collision radius. only by 5, because anything else doesn't feel good (one dies at a noticable distance from the cave), so there are probably cases left where one sees the universe, but i think this is a good compromise.

karyon commented 10 years ago

@carolinfiedler i think the black triangle is normal, it just has an improbably steep angle. i can't think of a reason why one single triangle should be broken.

karyon commented 10 years ago

i think this is good to go, could one of you two confirm?

mjendruk commented 10 years ago

:shipit: