search

mjesuele / gemini-api-node

Node.js client for the Gemini cryptocurrency exchange API
26 stars 17 forks source link

Adding TypeScript support #6

Closed evanshortiss closed 6 years ago

evanshortiss commented 6 years ago

Hi @mjesuele, thanks for this module.

I've been getting it up and running with TypeScript and needed some definitions to get started. They are not complete yet, but I'm opening this PR so you can confirm if you'd merge these or not. If not, then I will add them to DefinitelyTyped.

mjesuele commented 6 years ago

Hi @evanshortiss -- thanks for your contribution! I'd love to support TypeScript. Is this mergeable now or should I wait for more from you?

evanshortiss commented 6 years ago

@mjesuele, awesome! Not ready just yet, will @ you once it's updated 👍

evanshortiss commented 6 years ago

@mjesuele should be covered now 👍

evanshortiss commented 6 years ago

Actually. Going to test a little more.

evanshortiss commented 6 years ago

@mjesuele should be all good now!

mjesuele commented 6 years ago

@evanshortiss fantastic, thanks for this! merging now.