search

mjg / mupdf-spec

mupdf packaging for Fedora
https://copr.fedorainfracloud.org/coprs/mjg/mupdf-git
0 stars 0 forks source link

icon not working in application #3

Closed ousia closed 6 years ago

ousia commented 7 years ago

@mjg, here you have an image of both mupdf and xpdf displaying a file:

icon-mupdf

In both cases, titlebar doesn’t contain the application icon. But xpdf has the icon in the panel.

Would it be possible to fix at least the issue with the panel?

mjg commented 6 years ago

Fixed on master and in rawhide.

ousia commented 5 years ago

@mjg, I have just realized that mupdf-x11 has the icon, but I’m afraid that mupdf-gl doesn’t have it.

mupdf-gl-noicon

mjg commented 5 years ago

Does mupdf-x11 have the icon when you call it as "mupdf-x11" (not as "mupdf")?

ousia commented 5 years ago

Yes, it has it.

ousia commented 5 years ago

I’m afraid that mupdf-gl still lacks the icon, although I read:

mjg commented 5 years ago

Well, depends on which "the icon".

The desktop entry makes mupdf-gl appear in the menu (since it has an open dialog, as opposed to mupdf-x11); this is the important functional change. Also, it specifies an icon that desktop environments use in an app list, for iconified apps and such. All of this should work with mupdf-gl now.

The icon in the title bar is different: it's an x11 window decoration that - afaik - the app itself needs to set. From all that I can tell, mupdf-gl fails to set the icon through the glut library. (mupdf-x11 sets it directly using the x11-call.)