Move 0x644C and 0x644E to the LB1 class - Githubissues

mjg59 / python-broadlink

Python module for controlling Broadlink RM2/3 (Pro) remote controls, A1 sensor platforms and SP2/3 smartplugs

MIT License

1.38k stars 479 forks source link

Move 0x644C and 0x644E to the LB1 class #666

Closed felipediel closed 2 years ago

felipediel commented 2 years ago

Context

We recently added these two product ids (0x644C and 0X644E) to the wrong class. They work the same as LB1.

Proposed change

Move 0x644C and 0x644E to the LB1 class.

Type of change

[ ] Dependency upgrade
[x] Bugfix (non-breaking change which fixes an issue)
[ ] New device
[ ] New product id (the device is already supported with a different id)
[ ] New feature (which adds functionality to an existing device)
[ ] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests
[ ] Documentation

Additional information

This PR fixes issue: fixes #
This PR is related to:
- https://github.com/mjg59/python-broadlink/pull/636
- https://github.com/mjg59/python-broadlink/pull/644
Link to documentation pull request:

Checklist

[ ] The code change is tested and works locally.
[x] The code has been formatted using Black.
[x] The code follows the Zen of Python.
[x] I am creating the Pull Request against the correct branch.
[ ] Documentation added/updated.