Add Bestcon RM4C Pro 0x5218 - Githubissues

mjg59 / python-broadlink

Python module for controlling Broadlink RM2/3 (Pro) remote controls, A1 sensor platforms and SP2/3 smartplugs

MIT License

1.38k stars 479 forks source link

Add Bestcon RM4C Pro 0x5218 #680

Closed dtwilliamson closed 2 years ago

dtwilliamson commented 2 years ago

Context

Proposed change

Type of change

[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New device
[X ] New product id (the device is already supported with a different id)
[ ] New feature (which adds functionality to an existing device)
[ ] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests
[ ] Documentation

Additional information

IR works, but I'm unable to get RF to work trying with two unrelated RF remotes.

This PR fixes issue: fixes #
This PR is related to:
Link to documentation pull request:

Checklist

[X ] The code change is tested and works locally.
[ ] The code has been formatted using Black.
[ ] The code follows the Zen of Python.
[X ] I am creating the Pull Request against the correct branch.
[ ] Documentation added/updated.

felipediel commented 2 years ago

Thank you! You built on top of the wrong branch, so I created another PR and credited you: https://github.com/mjg59/python-broadlink/pull/683.