mjg59 / python-broadlink

Python module for controlling Broadlink RM2/3 (Pro) remote controls, A1 sensor platforms and SP2/3 smartplugs
MIT License
1.38k stars 479 forks source link

Add support for Broadlink RM4C mini (0x520D) #702

Closed Sparty117 closed 2 years ago

unrat commented 2 years ago

Is it just a coincidence that the ID for the RM4 mini and the RM4C mini is the same, or is this wrong labeled as RM4 mini? As I understand the naming of these Broadlink devices, the 'C' stands for 'no temp data' from the device. Does that somehow can be a problem if the devices with and without temp data have the same ID?

Sparty117 commented 2 years ago

What we ordered was “BroadLink RM4C Mini IR Black Bean Universal WIFI Remote Controller Receiver” and this is not showing any temperature data in the Broadlink app. My apologies you are correct, the model number should have been RM4C mini. I’ve updated the fork.

When we try to add the integration on HA we get “Device not supported” error and the HA logs show the device ID of 0x520D.

From: unrat @.> Sent: Monday, 25 July 2022 12:42 am To: mjg59/python-broadlink @.> Cc: Sparty117 @.>; Author @.> Subject: Re: [mjg59/python-broadlink] Add support for Broadlink RM4 mini (0x520D) (PR #702)

Is it just a coincidence that the ID for the RM4 and the RM4C is the same, or is this wrong labeled as RM4 mini? As I understand the naming of these Broadlink devices, the 'C' stands for 'no temp data' from the device. Does that somehow can be a problem if the devices with and without temp data have the same ID?

— Reply to this email directly, view it on GitHub https://github.com/mjg59/python-broadlink/pull/702#issuecomment-1193310853 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AWFCLWU6BWRA5SVXJQNADQDVVU2ZVANCNFSM54NSLYMQ . You are receiving this because you authored the thread. https://github.com/notifications/beacon/AWFCLWQPIL5TKCIUAC2EYGLVVU2ZVA5CNFSM54NSLYM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOI4QHVBI.gif Message ID: @. @.> >

kdeyev commented 2 years ago

I have faced the same issue and would like to use the fix, once it is merged.

felipediel commented 2 years ago

Thank you! Already available in the new_product_ids branch, it comes in the next release. If you want to patch Home Assistant before the release:

  1. Open Home Assistant and install "SSH & Web Terminal" add-on
  2. Disable Protection mode
  3. Click "Terminal" on the sidebar and install the patch:
    docker exec -it homeassistant /bin/bash
    pip3 install git+https://github.com/mjg59/python-broadlink.git@new_product_ids --force-reinstall --no-deps
  4. Restart the server.

You need to reinstall the patch if you update Home Assistant. It's not permanent.

Sparty117 commented 2 years ago

Thanks for this. Do you know when the next release is due? I’m on 2022.8.3 and I’m wondering are you referring to the release 2022.9.0?

Kind regards

Mark

From: Felipe Martins Diel @.> Sent: Sunday, 31 July 2022 12:48 am To: mjg59/python-broadlink @.> Cc: Sparty117 @.>; Author @.> Subject: Re: [mjg59/python-broadlink] Add support for Broadlink RM4C mini (0x520D) (PR #702)

Thank you! Already available in the new_product_ids branch, it comes in the next release. If you want to install the patch before the release:

— Reply to this email directly, view it on GitHub https://github.com/mjg59/python-broadlink/pull/702#issuecomment-1200151606 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AWFCLWR7XMQQOVX6KMV2FBLVWUP7VANCNFSM54NSLYMQ . You are receiving this because you authored the thread. https://github.com/notifications/beacon/AWFCLWVLCO3LL4KVUO4ASILVWUP7VA5CNFSM54NSLYM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOI6ENYNQ.gif Message ID: @. @.> >