mjg59 / python-broadlink

Python module for controlling Broadlink RM2/3 (Pro) remote controls, A1 sensor platforms and SP2/3 smartplugs
MIT License
1.38k stars 479 forks source link

New product ids 0x521C 0x520D 0x5211 0x648C #715

Closed titusthefox04 closed 1 year ago

titusthefox04 commented 2 years ago

Context

Proposed change

Add support for the follow new device ids:

Type of change

Additional information

Checklist

gtjadsonsantos commented 2 years ago

Any predictions for the pull request merge ?

unrat commented 2 years ago

Any predictions for the pull request merge ?

I would also appreciate a quick fix there as HA is using this repo and after every update of HA we have to manually fix this to get it working again. Is there anything i can do to speed things up?

kpblca commented 2 years ago

Me also voting for enforcing of merge this pull request into next release! =)

KingOfBaboon commented 2 years ago

yeah, it's a known issue and known fix, please merge and release, thanks!

mrosun commented 1 year ago

I just bought some of the new RM4C minis and they're not supported. I came to cast my vote to please merge this, thanks! And thank you for all your work as well!

jerrychong25 commented 1 year ago

Can someone help to approve this PR as soon as possible?

Thanks in advance!

kpblca commented 1 year ago

@mjg59 Mat, could you merge this PR to next release, please? This very useful change is stucked.

felipediel commented 1 year ago

Hi! This branch is internal, it will be merged as soon as I find the time to add some devices that are missing and prepare a new version, thanks!

gtjadsonsantos commented 1 year ago

Face this lib is very important to keep up to date, because it is used by several other applications and services, the home assistant is one of them, and very used by the people who use it.

I only see you currently @felipediel moving this lib forward with the time you have, the other maintainers are not moving this project forward. I understand that after years that this lib was born, it's fucked up to continue without a financial return yet. My advice is to open doors for more people who can maintain this.

Upgrading lib versions to add new devices even if it's one, two or three is better than going months without new versions to be added.

cfromm1911 commented 1 year ago

@felipediel Please add the missing devices.