Fix inaccurate hysen temperature

mjg59 / python-broadlink

Python module for controlling Broadlink RM2/3 (Pro) remote controls, A1 sensor platforms and SP2/3 smartplugs

MIT License

1.38k stars 479 forks source link

Fix inaccurate hysen temperature #720

Closed fustom closed 5 months ago

fustom commented 1 year ago

Context

Hysen heating thermostat returned inaccurate temperature.

Proposed change

Hysen payload[17] first half contains the the missing bits.

Type of change

[ ] Dependency upgrade
[x] Bugfix (non-breaking change which fixes an issue)
[ ] New device
[ ] New product id (the device is already supported with a different id)
[ ] New feature (which adds functionality to an existing device)
[ ] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests
[ ] Documentation

Additional information

This PR fixes issue: fixes #https://github.com/mjg59/python-broadlink/issues/678
This PR is related to:
Link to documentation pull request:

Checklist

[x] The code change is tested and works locally.
[x] The code has been formatted using Black.
[x] The code follows the Zen of Python.
[x] I am creating the Pull Request against the correct branch.
[ ] Documentation added/updated.

rjulius23 commented 1 year ago

@felipediel is it possible to get this to the latest release ?

felipediel commented 1 year ago

It may take a while for the next release, I'm swamped with work and no free time to work on this integration.

This code would also need a clean up and rebase, as it is incompatible with the current version of the dev branch. If the author doesn't know how to do it, I can help as soon as I have time.

Thanks for the contribution anyway, this is certainly something we want to add.

rjulius23 commented 1 year ago

Can this be released ?

rjulius23 commented 1 year ago

@felipediel it looks fine to me, does this need any further cleaning up ? How can I help ?

felipediel commented 1 year ago

Don't worry, I will merge it before the next release, I just don't have time for the whole release process right now, I will be back when I do

rjulius23 commented 1 year ago

Can I help with the release process ? Is there a guide ?

fustom commented 12 months ago

Happy 1st year anniversary.

rjulius23 commented 8 months ago

How can we push this to release ?

felipediel commented 8 months ago

Sorry, I am on a rush, I cannot change focus right now. To create a new release we need to analyze all breaking changes we've made since the last version and submit a PR to Home Assistant in order to keep it up to date.

I feel that I'm not giving enough attention to this project, but I just can't, my job is demanding everything I have. Maybe we need more people to help with updates, if anyone is interested ping mjg.

*Be aware that it takes some spare time and responsibility, this project has thousands of active users and if something breaks it needs to be fixed immediately.

rjulius23 commented 8 months ago

Hey @mjg59,

I can have some spare time to help out with some tasks. Can you link me a guid or tasks that I can do to help ?

cheers, Gyula

sancyx commented 8 months ago

It seems to me that this PR addresses the same problem as this: https://github.com/mjg59/python-broadlink/pull/720. Actually it seems a bit more accurate. I'm newbie in HASS and actually using Computherm E series thermostats with https://github.com/algirdasc/hass-floureon which is based on broadIink module. So not sure how can I help but would also love this to be fixed.

felipediel commented 5 months ago

Thank you @fustom! I believe that https://github.com/mjg59/python-broadlink/pull/772 has fixed the problem. If not, please reopen this PR.

fustom commented 5 months ago

Yeah #772 also works. I don't mind.