Expose durations beyond the CLI

wgrant commented 1 year ago

Context

Broadlink's IR/RF message protocol is well-understood, but translation between it and the standard microsecond duration format usable in other IR contexts is only accessible via broadlink_cli.

Proposed change

Move the two duration<->Broadlink functions from broadlink_cli to broadlink.remote, where they can be used by applications consuming the library.

Type of change

[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New device
[ ] New product id (the device is already supported with a different id)
[ ] New feature (which adds functionality to an existing device)
[ ] Breaking change (fix/feature causing existing functionality to break)
[x] Code quality improvements to existing code or addition of tests
[ ] Documentation

Checklist

[x] The code change is tested and works locally.
[x] The code has been formatted using Black.
[x] The code follows the Zen of Python.
[x] I am creating the Pull Request against the correct branch.
[ ] Documentation added/updated.

bengtmartensson commented 1 year ago

This is a good idea. However, the implementation conflicts with my PR #741. Either this PR should be rewritten on top of mine, or the other way around.

mjg59 / python-broadlink